We need to add Heap IDs to the Reader components on the S2 side of things, so I modified the PDF CL components to accept optional additional props.
Changes in this ticket:
Update the following components to receive additional props: BoundingBox, ZoomInButton, ZoomOutButton, PageWrapper, HighlightOverlay, Overlay, DownloadButton, Outline
Update existing DocumentWrapper variable name for additional props to match what was added for the other components
Put classNames on the DownloadButton, Outline, and OutlineItem components to make targeting these components from external sources easier
Reviewer Instructions
N/A
Testing Plan
Verified demo reader loads successfully and existing functionality still works as expected: zoom buttons, rotate buttons, outline w/ click target, highlight overlay, overlay, highlight text, download button.
Spot checked various components by adding bogus props to them in the demo app and confirming the props show up in the DOM. Removed these bogus props before submitting this PR though.
Description
Ticket: https://github.com/allenai/scholar/issues/31368 Subtask of: https://github.com/allenai/scholar/issues/31012
We need to add Heap IDs to the Reader components on the S2 side of things, so I modified the PDF CL components to accept optional additional props.
Changes in this ticket:
BoundingBox
,ZoomInButton
,ZoomOutButton
,PageWrapper
,HighlightOverlay
,Overlay
,DownloadButton
,Outline
DocumentWrapper
variable name for additional props to match what was added for the other componentsDownloadButton
,Outline
, andOutlineItem
components to make targeting these components from external sources easierReviewer Instructions
N/A
Testing Plan