allenai / pdf-component-library

51 stars 5 forks source link

Single PDF rendering component #126

Closed smitar closed 2 years ago

smitar commented 2 years ago

A single component that encapsulates Document Wrapper, outline, Page components etc. This might also fix the double scroll issue.

yensung commented 2 years ago

Some problems we have with current structure:

Proposal:

Benefits:

Works to do:

smitar commented 2 years ago

Blocked until we fix the double scroll bar. The PR creates a component to render all pdf pages but it also gonna be the scroll target for scroll functions to work on. However, we are keeping the outer scroll bar of the reader where the scroll target gonna be an element on S2 site, it conflicts with the PR. So, I’ll leave the PR open until Huy solves the double scroll bar, then we revisit it. Also, we may need to change the scroll functions in pdf-component-library if scroll target gonna be an element on S2 site.

smitar commented 2 years ago

No longer needed, we now have scroll context.