In order to make single canvas rendering works we still also need 6.0 version of react-pdf. Currently the official version is not yet published, they still just in beta.
Reviewer Instructions
Pull out the latest version into our repo. Performance mostly for other browser like Edge, Chrome, Firefox is normal. When it comes to Safari it does better than the old lagging state that we used to have as expected as last time i pull the repo, its not lagging any more but pages of pdf seem took longer than expected for rendering.
Testing Plan
Manually testing if the site works from both S2, Pdf component
Description
Ref: https://github.com/allenai/scholar/issues/32746 https://github.com/allenai/scholar/issues/32918
In order to make single canvas rendering works we still also need 6.0 version of
react-pdf
. Currently the official version is not yet published, they still just in beta.Reviewer Instructions
Pull out the latest version into our repo. Performance mostly for other browser like Edge, Chrome, Firefox is normal. When it comes to Safari it does better than the old lagging state that we used to have as expected as last time i pull the repo, its not lagging any more but pages of pdf seem took longer than expected for rendering.
Testing Plan
Manually testing if the site works from both S2, Pdf component
Output / Screenshots
Pdf Component Chrome https://user-images.githubusercontent.com/84343285/178374854-7a6498c4-ce9d-4318-b708-567197510a1a.mov
Firefox
https://user-images.githubusercontent.com/84343285/178375171-2c1c44ff-0c07-4b2e-8715-d86c9ddd57fc.mov
Edge
https://user-images.githubusercontent.com/84343285/178375272-e9566d65-0683-4315-b221-1443cfca752e.mov
Safari
https://user-images.githubusercontent.com/84343285/178375376-c92efee9-2565-47e8-ab64-49c55493cb28.mov
Scholar Chrome
https://user-images.githubusercontent.com/84343285/178375459-14f85fae-2582-4ced-895b-0abcdb06943f.mov
Firefox
https://user-images.githubusercontent.com/84343285/178375566-476a6c8c-0586-496f-afd6-3d8488568d28.mov
Edge
https://user-images.githubusercontent.com/84343285/178375645-ab4e44ae-ed72-4079-8691-1cb868c83cb8.mov
Safari
https://user-images.githubusercontent.com/84343285/178375729-4fb262d3-a3ba-474f-9728-ce392319be81.mov
A11y
No A11y involvement