search

allenai / pdf-component-library

44 stars 4 forks source link

recalibrate scroll on zoom #161

Closed ericmarsh995 closed 2 years ago

ericmarsh995 commented 2 years ago

Description

Fix known bug with react-pdf where zooming causes the scroll position to jump to different pages.

Reviewer Instructions

Testing Plan

Tested this on first page, middle page, and last page on both the demo and Semantic Reader

Output / Screenshots

Before

https://user-images.githubusercontent.com/108751850/182987245-c1e16199-778e-4efe-8fcc-28ec5b31ed8c.mov

After

https://user-images.githubusercontent.com/108751850/182987367-985cc9ff-2653-4dc4-9d84-d7c2af8c91a5.mov

A11y

N/A

huytr1995 commented 2 years ago

@ericmarsh995 can you do me a favor and test this in Prod by copy the yarn build files. Doing it this way will prevent us from fixing and publish multiple versions which can confuse our users