Hello World App State Management

carolinepaulic commented 3 years ago

This PR is a WIP but I'd like to start collecting feedback while I continue on unit tests.

Description

Ticket 28332. The goal of this ticket was to reduce the amount of props that are passed through multiple components and to avoid keeping all information related to state management in one blob within the top level app like we're currently doing in ScholarPhi.

Reviewer Instructions

I left comments on items I'd like you to take a closer look at.

Testing Plan

Manual tests:

PDF loads successfully
Zoom -/+ buttons and percentage display in header work correctly
Outline button in header opens drawer with outline
Clockwise and counterclockwise rotation buttons in header work correctly
Highlight Overlay button in header toggles highlight overlay display
BoundingBox examples are rendered on each page of the PDF
BoundingBoxes and HighlightOverlay respond to page scale and rotation changes
Outline drawer "X" button closes drawer
Clicking a list item in the outline scrolls to that item in the PDF

Unit tests:

Still working on adding tests for component

Output / Screenshots

The Hello World app should look and behave exactly the same as before.

carolinepaulic commented 3 years ago

I created a ticket with a task list for some of the items @pauls-ai2 brought up- https://github.com/allenai/scholar/issues/28926

carolinepaulic commented 3 years ago

Closing- I broke this up into smaller PRs.

allenai / pdf-component-library