allenai / pdf-component-library

51 stars 5 forks source link

Refactor PDF Component Layout to be single scrollbar #189

Closed huytr1995 closed 2 years ago

huytr1995 commented 2 years ago

Description

Ref: https://github.com/allenai/scholar/issues/33432

The PDF Component library still has double scroll bar. This PR addresses it.

Reviewer Instructions

Eventually we will eliminate the feature flag and make our single scroll bar becomes primary. To keep it consistent with Prod we would want to make sure our component library will be like that so we can have a consistency between two environment for a better development time too. I got rid of the double scrollbar and make it single to look like Prod.

Testing Plan

Manually makes sure after layout changes for Demo App everything works.

Output / Screenshots

https://user-images.githubusercontent.com/84343285/187794343-e31ef194-6041-4833-b2de-4bfc636802ac.mov

A11y

No A11y involvement.