search

allenai / pdf-component-library

44 stars 4 forks source link

Adding Thumbnails into PDF Component #194

Closed huytr1995 closed 2 years ago

huytr1995 commented 2 years ago

Description

Ref: https://github.com/allenai/scholar/issues/30370 Figma: https://www.figma.com/file/2gUmD3D8tz6gnm9rsYgj6J/Semantic-Reader?node-id=3634%3A37853

This PR adds Thumbnail in PDF Component Library.

Reviewer Instructions

Create Thumbnail in PDF Component library. Due to the way we render the Outline in PDF Component library is different compare to S2. So i created a button for Thumbnail and when get clicked it will render similar to how Outline does. When input in S2 since it has ReaderSidePanel i can put it in there like how @ctrier has in Figma design.

Testing Plan

Output / Screenshots

https://user-images.githubusercontent.com/84343285/191814197-bc482dff-d519-4498-80ab-3dba18684bec.mov

A11y

https://user-images.githubusercontent.com/84343285/191613782-33a5e23a-05ce-4a68-9af8-3810453e859b.mov

ctrier commented 2 years ago

@huytr1995 I think maybe the first two videos you uploaded are the same video. Did you mean to upload a different one?

I'm also wondering what's happening here at 0:18 seconds in the video. It seems like 3 pages are highlighted? What scenario is leading to this?

Screen Shot 2022-09-21 at 3 48 17 PM
huytr1995 commented 2 years ago

@huytr1995 I think maybe the first two videos you uploaded are the same video. Did you mean to upload a different one?

I'm also wondering what's happening here at 0:18 seconds in the video. It seems like 3 pages are highlighted? What scenario is leading to this?

Screen Shot 2022-09-21 at 3 48 17 PM

@ctrier hi cassidy yeah it was the same video i thought i didnt get that part in. I will double check that 3 highlight scenario

huytr1995 commented 2 years ago

Just waiting on a resolution on the issue with the fast scrolling jamming up the IntersectionObserver

@ctrier i fixed it checked the video again. I replaced the old video with the new one :)