search

allenai / pdf-component-library

51 stars 5 forks source link

Adding tab ability in Thumbnail for Acessibility #196

Closed huytr1995 closed 2 years ago

huytr1995 commented 2 years ago

Description

Ref: https://github.com/allenai/scholar/issues/30370

Thumbnail cant be tabbed in Semantic Reader so I added href with pageNumber to be able to tab.

Reviewer Instructions

Adding Tab ability.

Testing Plan

Verify user can tab it using keyboard. Other than that yarn format, lint, test

A11y

https://user-images.githubusercontent.com/84343285/192043301-8a898b98-fb6e-476b-ae33-ab345b7ad5e5.mov