search

allenai / pdf-component-library

44 stars 4 forks source link

Move latest from scholar #205

Closed undfined closed 1 year ago

undfined commented 1 year ago

This is a maintenance task to move latest version of the package from Scholar. This should be backwards compatible update but likely warrants a major version bump to delineate the transition to the new project development structure.

ericmarsh995 commented 1 year ago

Have you tried testing the demo? When I tested your changes, I get a lot of text overlap and the page is off center. Not sure if this is just my machine though, but the demo works fine on the main branch.

https://github.com/allenai/pdf-component-library/assets/108751850/ca81a420-c8f4-4576-9943-062d1dc035f2

undfined commented 1 year ago

Have you tried testing the demo? When I tested your changes, I get a lot of text overlap and the page is off center. Not sure if this is just my machine though, but the demo works fine on the main branch.

Screen.Recording.2023-05-25.at.12.50.34.PM.mov

I think I missed the less files, checking now.

undfined commented 1 year ago

@ericmarsh995 ok can you check the demo now?

ericmarsh995 commented 1 year ago

I tested it and the formatting issues are solved 👍

yensung commented 1 year ago

Should it be able to run after running docker-compose up --build? It failed to bring containers up on my local

Screen Shot 2023-05-25 at 14 13 59

It stuck at the COPY step

undfined commented 1 year ago

Looks like some file conflicts, can you clear you docker cache / restart docker and try again? Was working for me but I started fresh.

On Thu, May 25, 2023 at 14:20 yensung @.***> wrote:

Should it be able to run after running docker-compose up --build? It failed to bring containers up on my local [image: Screen Shot 2023-05-25 at 14 13 59] https://user-images.githubusercontent.com/84034381/241062075-4807be66-4b8d-482d-810d-10a5dc3e892d.png

It stuck at the COPY step

— Reply to this email directly, view it on GitHub https://github.com/allenai/pdf-component-library/pull/205#issuecomment-1563519886, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHJAQEPAONE6OFMNVABQYLXH7EJXANCNFSM6AAAAAAYPC2ALU . You are receiving this because you authored the thread.Message ID: @.***>

ericmarsh995 commented 1 year ago

Should it be able to run after running docker-compose up --build? It failed to bring containers up on my local

I ran into this issue too and deleting node_modules in ui/library solved it