28926 subtask: SimpleZoomControl uses context vars instead of props - Githubissues

allenai / pdf-component-library

51 stars 5 forks source link

28926 subtask: SimpleZoomControl uses context vars instead of props #21

Closed carolinepaulic closed 3 years ago

carolinepaulic commented 3 years ago

Description

This is a subtask of https://github.com/allenai/scholar/issues/28926 and a continuation of the state management work from https://github.com/allenai/scholar/issues/28332.

I updated the SimpleZoomControl component to use the new context vars over props to reduce redundancy.

Reviewer Instructions

This includes @pauls-ai2 suggestion of splitting handleZoom into handleZoomIn and handleZoomOut

Testing Plan

Manually test zoom in and zoom out functionality
Run all unit tests