Type definitions: Citation - Githubissues

allenai / pdf-component-library

51 stars 5 forks source link

Type definitions: Citation #29

Closed carolinepaulic closed 3 years ago

carolinepaulic commented 3 years ago

Description

This covers the Citation subtask of https://github.com/allenai/scholar/issues/28339

Original changes in this PR:

New types for Citation, CitationPaper, and Author based on what is returned by ScholarPhi's citation endpoint

New changes in this PR:

Split up the existing types file:
- Moved types used by the library components (just Size and BoundingBox) into a new types file in the library
- Moved types related to citations into a new citations file
- Old file now contains types for base entities and is called entity
Renamed data dir to types
Moved contents of src/types.ts (just the Nullable type) into the library types file and deleted old file

Testing Plan

Ran all unit tests