allenai / pdf-component-library

51 stars 5 forks source link

28683 Sample Paper subtask: Move PDF load handlers out of Reader #34

Closed carolinepaulic closed 3 years ago

carolinepaulic commented 3 years ago

Description

This covers the moving PDF handlers subtask of https://github.com/allenai/scholar/issues/28683. The PDF load success/error handler functions do not belong in the example Reader app. These functions are necessary for the PDF to load correctly so I moved them into the DocumentWrapper component of the library (previously Reader was passing these functions to the DocumentWrapper as props).

Changes in this PR:

Testing Plan