allenai / pdf-component-library

51 stars 5 forks source link

29577 Refactor computeStyleWithContext + unit tests #40

Closed carolinepaulic closed 3 years ago

carolinepaulic commented 3 years ago

Description

This covers the bulk of https://github.com/allenai/scholar/issues/29577 which is a subtask of the PDF Component Library Loose Ends ticket.

Changes in this PR:

Reviewer Instructions

Don't be discouraged by how many LOC were changed in this PR! Most of it is variable renaming due to the pageSize > pageDimensions thing and the unit tests added 400+ LOC as well. I tried to split my commits up nicely so you can step through those if that's useful.

Testing Plan