allenai / pdf-component-library

51 stars 5 forks source link

29650 Demo app uses PDF Component Library package #59

Closed carolinepaulic closed 2 years ago

carolinepaulic commented 2 years ago

Description

Update demo app such that it imports PDF Component Library components from the pdf-components-dist npm package instead of directly from the library directory.

Changes in this PR:

Reviewer Instructions

Please take a look at how I included the PDFjs worker and let me know if this could've been done a better way. Also interested in your thoughts on the demo app running off of the local package instead of the published one.

Testing Plan

mjlangan commented 2 years ago

Re: Also interested in your thoughts on the demo app running off of the local package instead of the published one.

Yes we should definitely run the demo using the local package. Doing it otherwise makes using the demo to modify the library really difficult as every change would need to be published to NPM to be tested.