Closed carolinepaulic closed 2 years ago
Re: Also interested in your thoughts on the demo app running off of the local package instead of the published one.
Yes we should definitely run the demo using the local package. Doing it otherwise makes using the demo to modify the library really difficult as every change would need to be published to NPM to be tested.
Description
Update demo app such that it imports PDF Component Library components from the
pdf-components-dist
npm package instead of directly from the library directory.Changes in this PR:
pdf-components-dist
npm package instead of library directoryDocumentWrapper
, otherwise PDF won't load once we use package instead of library directorypackage.json
files to link PDF lib package to demo app and updated GitHub CI process to include new linking stepslibrary/dist
rather than from the npm registry. I went in this direction because the demo app is intended to aid local development of the library rather than to test what is up on npm.Reviewer Instructions
Please take a look at how I included the PDFjs worker and let me know if this could've been done a better way. Also interested in your thoughts on the demo app running off of the local package instead of the published one.
Testing Plan