29912- Import package into S2 & render PDF (part 1) - Githubissues

allenai / pdf-component-library

44 stars 4 forks source link

29912- Import package into S2 & render PDF (part 1) #61

Closed carolinepaulic closed 2 years ago

carolinepaulic commented 2 years ago

Description

Issue #29912. The goal is to render a PDF in Semantic Scholar using a version of the PDF Component Library that's deployed to npm.

Changes in this PR:

Library Webpack config changes: publicPath: '' and globalObject: this to fix errors described in ticket comments
PDF worker setup changes: moved worker init to new util file to keep it contained and updated workerSrc setup to leverage Webpack to find worker entry instead of hardcoding it
Library build: updated to v0.0.7 with the latest changes in this PR, tagged with v0.0.7, and published to npm.

Reviewer Instructions

The PR for the S2 side of things is here.

Ideally this PR will be merged before the S2 PR.

Testing Plan

Tested all existing demo app functionality.
Tested importing the published library into S2 and rendering a PDF with it.