search

allenai / pdf-component-library

44 stars 4 forks source link

docker updates to fix broken deployment #94

Closed smitar closed 2 years ago

smitar commented 2 years ago

Fixes: https://github.com/allenai/pdf-component-library/issues/64

Based on the changes suggested by M in this PR

Testing: Ran docker-compose up -build from projects root folder. Verified http://localhost:8080/ Made changes to the code and verified changes are compiled automatically and reflect in http://localhost:8080/

carolinepaulic commented 2 years ago

Does the .dockerignore file need to be updated? Some of those paths look like they may be out of date

smitar commented 2 years ago

Does the .dockerignore file need to be updated? Some of those paths look like they may be out of date

What in the .dockerignore file is out of date?

carolinepaulic commented 2 years ago

Does the .dockerignore file need to be updated? Some of those paths look like they may be out of date

What in the .dockerignore file is out of date?

I was looking at this, but I don't think this is relevant anymore since this is probably pattern matching like the .gitignore: image

smitar commented 2 years ago

Does the .dockerignore file need to be updated? Some of those paths look like they may be out of date

What in the .dockerignore file is out of date?

I was looking at this, but I don't think this is relevant anymore since this is probably pattern matching like the .gitignore: image

Yes this would be pattern match too.