Fix dependency issues for Scala 2.11 and 2.12

yasithdev commented 2 years ago

I've updated the dependencies to more recent versions, and fixed issues that prevented running sbt assembly to create a standalone .jar file. The specific changes are as follows.

Updated dependencies to their latest versions
replace org.allenai.common:common-testkit tests with org.scalatest:scalatest
the test case of getting a Table and a Figure were returned in reverse order, thus failing the test. I swapped their indices (in the get() function) so that it passes.
I fixed the sbt assembly plugin issues and got the JAR to build.

Appreciate if this could me reviewed and merged!

CommanderPho commented 1 year ago

This version works well on RHEL 8, resolving the issues I was experiencing with sbt assembly and sbt test failing with the master branch. Looks great to me, I'd vote to merge. :+1:

sidharthrajaram commented 12 months ago

Pretty great. This should be merged. 👍

OrianeN commented 12 months ago

Worked great on Ubuntu-20.04 as well after a lot of struggling to install Scala and run sbt assembly ! Thank you very much @yasithdev for sharing your fix !

Ryandonofrio3 commented 11 months ago

Highly recommend! Working Windows 11. Suggest merge to main.

chrisc36 commented 10 months ago

Had cause to look back at this and this pull does fix the assembly issue, thanks!

allenai / pdffigures2

Fix dependency issues for Scala 2.11 and 2.12 #51