Closed TheRealKeto closed 2 years ago
Hey @TheRealKeto, I'm a little confused about what the point of this is. I can see importing
VERSION
into the main__init__.py
being useful, but why change the name ofVERSION
toRELEASE
andVERSION_SHORT
toVERSION
?
That was mostly after seeing that the Sphinx configuration refers to VERSION_SHORT
as VERSION
and VERSION
as RELEASE
; I think this makes more sense, but the change can be reverted.
Gotcha, thanks for clarifying. Personally I think VERSION
and VERSION_SHORT
are more clear, so I'd to keep it that way.
The latest commit reverts the renaming of version variables :)
This PR correctly "exports" version variables after package initialization. What this means is that, rather than importing
my_package/version.py
, you can just importmy_package
as a whole (though technically, the old behavior is still there)