search

allenai / s2-folks

Public space for the user community of Semantic Scholar APIs to share scripts, report issues, and make suggestions.
Other
144 stars 25 forks source link

Rename test scripts to test.py #105

Closed dirkraft closed 1 year ago

dirkraft commented 1 year ago

due to a change in https://github.com/allenai/s2-folks/pull/94#issuecomment-1554836690 to simplify/assume any example test scripts are also python

dirkraft commented 1 year ago

if you look at https://github.com/allenai/s2-folks/actions/runs/5074580424/jobs/9114905721#step:4:12 and cmd+f for > Running you will find three example test scripts that got run

yoganandc commented 1 year ago

why remove the shebang i dont get it

dirkraft commented 1 year ago

these are run explicitly with python now: https://github.com/allenai/s2-folks/blob/main/examples/python/run_tests.sh#L19

guess it doesn't matter, but would rather have consistency than imply we are detecting how to run these test scripts. we are not.