allenai / scholarphi

An interactive PDF reader.
Apache License 2.0
416 stars 52 forks source link

Fine-tune the behavior and appearance of discourse tag buttons #327

Closed andrewhead closed 2 years ago

andrewhead commented 2 years ago

This PR contributes changes to both the functionality and the appearance of the discourse tag filters.

The first change is around the functionality. Like before, when a reader opens the drawer, they see a list of sentences belonging to all discourse categories. However, unlike before, when a reader clicks on one of the tags, then only that tag gets selected and all others are deselected. This behavior applies for the first tag selection only.

Then, if a reader wish to enable all tags they can click the "Everything" button, which selects all tags. If all tags are selected, the "Everything" button appears selected, and the reader can deselect all tags by clicking the "Everything" button again.

This PR also includes a few style fixes, including:

scim-selections