search

allenai / scholarphi

An interactive PDF reader.
Apache License 2.0
420 stars 54 forks source link

deprecate partner subdomain for s2-api.ts #383

Closed stupendousC closed 1 year ago

stupendousC commented 1 year ago

As mentioned in preceding Deprecate partner subdomain #382 (which takes care of the data-processing/ side), this PR is for the api side.

BTW, the changes here are already approved for the main branch in PR #381 . We're just trying to maintain some kind of consistency between the 2 branches here.

Also, we're pretty sure that NOBODY is even calling the api code in scholarphi anymore, but IF things were to blow up, then we know to reverse this PR (for this branch or for main branch, depending on what happens).

stupendousC commented 1 year ago

haha i hear you loud and clear. I'll accept the blame if I messed stuff up 🙏