allenai / scispacy

A full spaCy pipeline and models for scientific/biomedical documents.
https://allenai.github.io/scispacy/
Apache License 2.0
1.66k stars 223 forks source link

Configuration for model locations #469

Open buddha314 opened 1 year ago

buddha314 commented 1 year ago

Allows for abstract model locations away from AWS. This file sets AWS as model source

https://github.com/allenai/scispacy/blob/main/scispacy/candidate_generation.py

For instance https://github.com/allenai/scispacy/blob/main/scispacy/candidate_generation.py#L43

Allow these to be set by environment or configuration files.

dakinggg commented 1 year ago

Makes perfect sense @buddha314, I'd be happy to accept a PR doing this!

buddha314 commented 1 year ago

Initial thinking is to take the root url as an environment variable with the AWS location as the default.

dakinggg commented 1 year ago

Makes sense, I might consider making a new LocalLinkerPaths that reads from environment variables.