search

allenai / scispacy

A full spaCy pipeline and models for scientific/biomedical documents.
https://allenai.github.io/scispacy/
Apache License 2.0
1.66k stars 223 forks source link

add progress bar to http_get #496

Closed WeixiongLin closed 9 months ago

WeixiongLin commented 10 months ago

I have discussed with the maintainer in issue-490, and encouraged to raise this PR.

Gist: To use scispacy, some of the resources are fetched from web url, e.g. URL of tfidf_vectors_sparse. And the size of the resources could be up to 500M, thereby taking several miutes to complete downloading. Somehow scispacy download quietly without signals for users, so thet can't tell whether the progress stucks or not.

So I add a progress bar to the function http_get to let users know where they are.

Scispacy helps me a lot in my research, thanks for your contribution to our community. And thanks for your review.

WeixiongLin commented 9 months ago

Could you run the autoformatter? black scispacy --line-length 88

Otherwise, looks good to me, thank you!

OK.

WeixiongLin commented 9 months ago

There's something wrong with my downstream repo, I have to close this PR and raise a new one. I have run the black formatter by the way.