search

allenai / scispacy

A full spaCy pipeline and models for scientific/biomedical documents.
https://allenai.github.io/scispacy/
Apache License 2.0
1.72k stars 229 forks source link

add progress bar to http_get #499

Closed WeixiongLin closed 1 year ago

WeixiongLin commented 1 year ago

I have discussed with the maintainer in issue-490, and encouraged to raise this PR.

Gist: To use scispacy, some of the resources are fetched from web url, e.g. URL of tfidf_vectors_sparse. And the size of the resources could be up to 500M, thereby taking several miutes to complete downloading. Somehow scispacy download quietly without signals for users, so thet can't tell whether the progress stucks or not.

So I add a progress bar to the function http_get to let users know where they are.

Scispacy helps me a lot in my research, thanks for your contribution to our community. And thanks for your review.

WeixiongLin commented 1 year ago

There was somthing wrong with my downstream repo so I close the old PR and raise this one again. And I have checked the code format with black scispacy --line-length 88 by the way.

WeixiongLin commented 1 year ago

I have fix the problem, thanks for your help.