search

allenai / semanticilp

Question Answering as Global Reasoning over Semantic Abstractions (AAAI-18)
Apache License 2.0
33 stars 13 forks source link

Fix memory leak #2

Closed ashish33 closed 6 years ago

ashish33 commented 6 years ago

There was a native memory leak from IlpSolver as the constructed ILP object wasn't properly freed up in the C++ land without an explicit call to ilpsolver.free(). That's fixed now and the native memory footprint seems stable (does not grow with the number of questions, for 1000+ questions). In addition:

danyaljj commented 6 years ago

Looks good to me. Thanks!

Merging.