search

allenap / shell-quote

A Rust library for shell quoting strings, e.g. for interpolating into a Bash script. This is not as simple as most people think!
Apache License 2.0
5 stars 2 forks source link

Failing to build on Windows #1

Closed KSXGitHub closed 11 months ago

KSXGitHub commented 1 year ago

Windows do have BASH Shell. So I think this crate could be useful there. I also want to use this crate in my cross-platform application.

allenap commented 1 year ago

Hi @KSXGitHub, can you share the build errors from Windows?

KSXGitHub commented 1 year ago

@allenap It was caused by this line: https://github.com/allenap/shell-quote/blob/5624564590927c1d1f7d34f02cb9cb50d551f2d5/src/sh.rs#L49

Windows doesn't have std::os::unix.

allenap commented 11 months ago

Hi @KSXGitHub, the 0.5.0 release avoids importing std::os::unix so this ought to compile on Windows now. The API has changed a lot, but there are examples in the docs.

Of course, I may have made a mistake – I haven't configured CI for Windows yet, and I don't have a Windows machine with tooling on it to test – so if you're still interested in this package, please let me know if you hit issues. For the moment I'm able to respond more quickly than before.

KSXGitHub commented 11 months ago

@allenap I have already forgot why I wanted to use this crate, so you cannot expect me to test your new release now.

allenap commented 11 months ago

Fair enough.