search

allenap / shell-quote

A Rust library for shell quoting strings, e.g. for interpolating into a Bash script. This is not as simple as most people think!
Apache License 2.0
5 stars 2 forks source link

Several fish binaries are included in crate published on crates.io #33

Open kxxt opened 6 days ago

kxxt commented 6 days ago

Hi,

Not a big problem. I noticed that shell-quote is the largest dependency I used:

  Downloaded 195 crates (30.5 MB) in 13.86s (largest was `shell-quote` at 5.9 MB)

I inspected the crate and found several fish binaries in it:

tar tvf shell-quote-0.7.1.crate
-rw-r--r-- 0/0            1812 2006-07-24 09:21 shell-quote-0.7.1/.github/workflows/build.yml
-rw-r--r-- 0/0              20 2006-07-24 09:21 shell-quote-0.7.1/.gitignore
-rw-r--r-- 0/0              83 2006-07-24 09:21 shell-quote-0.7.1/.vscode/extensions.json
-rw-r--r-- 0/0             336 2006-07-24 09:21 shell-quote-0.7.1/.vscode/settings.json
-rw-r--r-- 0/0            1486 1970-01-01 08:00 shell-quote-0.7.1/Cargo.toml
-rw-r--r-- 0/0             924 2006-07-24 09:21 shell-quote-0.7.1/Cargo.toml.orig
-rw-r--r-- 0/0           11358 2006-07-24 09:21 shell-quote-0.7.1/LICENSE
-rw-r--r-- 0/0              47 2006-07-24 09:21 shell-quote-0.7.1/Makefile
-rw-r--r-- 0/0            7055 2006-07-24 09:21 shell-quote-0.7.1/README.md
-rw-r--r-- 0/0            1261 2006-07-24 09:21 shell-quote-0.7.1/benches/bash.rs
-rw-r--r-- 0/0            1261 2006-07-24 09:21 shell-quote-0.7.1/benches/fish.rs
-rw-r--r-- 0/0            1265 2006-07-24 09:21 shell-quote-0.7.1/benches/sh.rs
-rwxr-xr-x 0/0         5956640 2006-07-24 09:21 shell-quote-0.7.1/fish/3.3.1/fish
-rwxr-xr-x 0/0         6303232 2006-07-24 09:21 shell-quote-0.7.1/fish/3.6.1/fish
-rwxr-xr-x 0/0         5886576 2006-07-24 09:21 shell-quote-0.7.1/fish/3.6.4/fish
-rwxr-xr-x 0/0              79 2006-07-24 09:21 shell-quote-0.7.1/fish/with
-rw-r--r-- 0/0            3406 2006-07-24 09:21 shell-quote-0.7.1/src/ascii.rs
-rw-r--r-- 0/0           11567 2006-07-24 09:21 shell-quote-0.7.1/src/bash.rs
-rw-r--r-- 0/0           11764 2006-07-24 09:21 shell-quote-0.7.1/src/fish.rs
-rw-r--r-- 0/0            6111 2006-07-24 09:21 shell-quote-0.7.1/src/lib.rs
-rw-r--r-- 0/0            9175 2006-07-24 09:21 shell-quote-0.7.1/src/sh.rs
-rw-r--r-- 0/0            2692 2006-07-24 09:21 shell-quote-0.7.1/src/utf8.rs
-rw-r--r-- 0/0             492 2006-07-24 09:21 shell-quote-0.7.1/test.py
-rw-r--r-- 0/0             154 2006-07-24 09:21 shell-quote-0.7.1/tests/resources/mod.rs
-rw-r--r-- 0/0           64269 2006-07-24 09:21 shell-quote-0.7.1/tests/resources/utf8.html
-rw-r--r-- 0/0            6895 2006-07-24 09:21 shell-quote-0.7.1/tests/test_bash.rs
-rw-r--r-- 0/0           10607 2006-07-24 09:21 shell-quote-0.7.1/tests/test_fish.rs
-rw-r--r-- 0/0            7863 2006-07-24 09:21 shell-quote-0.7.1/tests/test_sh.rs
-rw-r--r-- 0/0            6731 2006-07-24 09:21 shell-quote-0.7.1/tests/test_ux.rs
-rw-r--r-- 0/0             979 2006-07-24 09:21 shell-quote-0.7.1/tests/util/mod.rs

It would be nice if you could exclude such binaries from the crate when publishing. Thanks!

allenap commented 5 days ago

Oh yes, good spot. I don't think these will get bundled into your compiled binaries, so it's only a development-time download burden, but perhaps there's something I can do about it. There's no real point in uploading those fish binaries to crates.io – or indeed any test resources or the tests themselves.

kxxt commented 5 days ago

but perhaps there's something I can do about it.

Perhaps you can avoid such problems by running cargo publish in GitHub Actions