search

allenfrostline / Poker

Poker: A Simple Poker GUI in Python
15 stars 2 forks source link

Game config screen cutoff or fields missing? #4

Open MikeTheWatchGuy opened 5 years ago

MikeTheWatchGuy commented 5 years ago

On this screen, it looks like something is being cut off: image

There is also no way to "exit" that screen (by closing window or an Exit button).

allenfrostline commented 5 years ago

All these bugs seems only happening on Windows. I have tested on multiple Mac OS versions and the window structures were the same and fine. Will create an issue with all windows' screenshots for reference.

MikeTheWatchGuy commented 5 years ago

It's a portability problem and I'm not so sure it's limited to Windows. I haven't tried on Mint or other Linux ports.

One problem with pixel counting and manually padding is that 240 pixels on one OS / Monitor combination may not be the same as another.

The reason the main window was so badly cut off was the size was set manually versus letting the underlying GUI do it.

This will limit you from going to other ports in the future as well (Qt, Wx, Web). Not all of the features are ready in the other ports for what you're doing except maybe Qt,. but they will some day. I'm slowly getting there.

allenfrostline commented 5 years ago

I see. I just double checked your documentation and I think most problems are coming from Tkinter on Mac. I'll try to convert the current version to a Qt one. Several slight changes will need to be made. Also, base64 images are ready. So there is expected to have no image files at all in the Qt version. Nice suggestion! Thanks.

MikeTheWatchGuy commented 5 years ago

Wait on a Qt port....

Images drawn on Graphs aren't done from what I recall.

Base64 images should be supported fully in tkinter now. If you find a spot where they are not, let me know. You may have to look at the function call in the source to be sure sometimes.