search

allenh1 / p2os

P2OS ROS driver for Groovy and later.
http://wiki.ros.org/p2os-purdue
27 stars 38 forks source link

Two fixes for Melodic. #62

Closed clalancette closed 5 years ago

clalancette commented 5 years ago

In p2os_driver, the p2os_msgs_gencpp doesn't exist (and, as far as I can tell, never existed). It worked up until recently because older versions of CMake would complain but not fail, while more recent cmake versions actually fail. Just remove the dependency.

The second fix is a cosmetic issue, where CMake would spew a bunch of warnings on the command line. Increase the version to 3.9.5 to match other CMakeLists.txt and to get rid of the warnings.

@allenh1 This should fix the current problems on the ROS buildfarm here.

clalancette commented 5 years ago

(also, assuming you agree to and merge this fix, a new release into Melodic ASAP would be appreciated)

allenh1 commented 5 years ago

@clalancette thank you much! Looks great.