search

allenhwkim / ngentest

Angular6+ Unit Test Generator For Components, Directive, Services, and Pipes
https://ngentest.github.io
MIT License
144 stars 60 forks source link

Bugs on new versions #70

Closed daniarza closed 1 year ago

daniarza commented 1 year ago

Hi there!

I want notice the team that i found two bugs on the last modifications.

  1. tsFilePath is not defined, should be used tsPath instead.

    Screenshot 2023-09-04 at 09 47 08

  2. Util.FRAMEWORK never returns 'karma' value. It only returns 'jest' or true. Getter should be static get FRAMEWORK() { return Util.__framework ?? 'jest'; } or something similar.

Screenshot 2023-09-04 at 09 50 13

Thank you and regards,

Daniel.

allenhwkim commented 1 year ago

Thanks for reporting bugs. Fixed and released new version 2.2.1

@daniarza I see you are new to Github. It would be nice for you to make a PR from a fork, so that you can be on a contributors list.