allenluce / logcap

Golang testing for Logrus logs
2 stars 0 forks source link

Dependency on wrong-case version of logrus #1

Closed joemcmahon closed 4 years ago

joemcmahon commented 6 years ago

If you've already followed the instructions at github.com/sirupsen/logrus (note lower-case), then this module fails to resolve properly during dep ensure.

(12)  ? attempt github.com/allenluce/logcap with 1 pkgs; 1 versions to try
(13)      try github.com/allenluce/logcap@master
(14)  ✗   case-only variation in dependency on "github.com/Sirupsen/logrus"; "github.com/sirupsen/logrus" already established by:
(14)    (root)
(13)    ← no more versions of github.com/allenluce/logcap to try; begin backtrack
(12)  ← backtrack: no more versions of github.com/spf13/pflag to try
(11)  ← backtrack: no more versions of github.com/inconshreveable/mousetrap to try
(10)  ← backtrack: no more versions of github.com/spf13/cobra to try
(9) ← backtrack: no more versions of golang.org/x/net to try
(8) ← backtrack: no more versions of github.com/mitchellh/go-homedir to try
(7) ← backtrack: popped 5 pkgs from github.com/golang/protobuf
(6) ← backtrack: no more versions of google.golang.org/grpc to try
(5) ← backtrack: no more versions of github.com/sirupsen/logrus to try
(4) ← backtrack: no more versions of github.com/hpcloud/tail to try
(3) ← backtrack: no more versions of github.com/onsi/ginkgo to try
(2) ← backtrack: no more versions of github.com/golang/protobuf to try
(1) ← backtrack: no more versions of github.com/disiqueira/gotree to try
  ✗ solving failed

It would probably be better to change the case of the import in this module too. I'm sure there's a dep workaround, and I will use it -- but fixing this is probably better in the long run.

allenluce commented 4 years ago

Sorry I'd missed this! I actually put in the fix before noticing you'd opened an issue & submitted a pull request on it.

joemcmahon commented 4 years ago

No worries. Just glad the fix is in. :)

On Thu, Oct 8, 2020 at 3:27 PM Allen Luce notifications@github.com wrote:

Sorry I'd missed this! I actually put in the fix before noticing you'd opened an issue & submitted a pull request on it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/allenluce/logcap/issues/1#issuecomment-705855981, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAO6G2FEA5M2AYAQFVV64LSJY4E7ANCNFSM4FS4AROA .