search

allentc / pgadmin3-lts

Other
29 stars 33 forks source link

Use external libssh2 #13

Closed SebDieBln closed 2 years ago

SebDieBln commented 2 years ago

This PR changes the code so that it has libssh2 as an external dependency instead of bundling it with the source of pgAdmin3. The bundled version was heavily outdated and did not compile with Postgres later than 9.2.24.

While working on the change I also came up with a github-workflow to build on Ubuntu (thanks to @proxy-m for pointing me into the right direction). This should increase the confidence in this and future PRs to not break anything.

SebDieBln commented 2 years ago

@allentc Thanks for merging my PR and the ones before, I really appreciate it!

allentc commented 2 years ago

Glad to do it. I ended up inheriting this repo as a result of forking it from a repo that vanished at some point. I'm not actively developing it's but I'll continue to review and merge contributions and perhaps help to keep the work consolidated in one repo.

proxy-m commented 2 years ago

@SebDieBln , You are welcome. README update: https://github.com/allentc/pgadmin3-lts/pull/15