allentc / pgadmin3-lts

Other
29 stars 33 forks source link

ld: error: utils/sshTunnel.o: unable to find library from dependent library specifier: Ws2_32.lib #19

Open VVD opened 2 years ago

VVD commented 2 years ago

Without this patch:

--- pgadmin/utils/sshTunnel.cpp.orig    2016-02-08 10:25:13 UTC
+++ pgadmin/utils/sshTunnel.cpp
@@ -19,7 +19,9 @@
 #include "utils/sshTunnel.h"
 #include "frm/frmMain.h"

+#ifdef WIN32
 #pragma comment (lib, "Ws2_32.lib")
+#endif

 typedef const char *(*inet_ntop_t) (int af, const void *src, char *dst, socklen_t size);

https://cgit.freebsd.org/ports/tree/databases/pgadmin3/files/patch-pgadmin_utils_sshTunnel.cpp I get this error during build:

ld: error: utils/sshTunnel.o: unable to find library from dependent library specifier: Ws2_32.lib
c++: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[4]: *** [Makefile:5227: pgadmin3] Error 1
allentc commented 2 years ago

Please create Pull Requests for all such changes. The fix is straight forward and I'll gladly accept it.

VVD commented 2 years ago

How to do Pull Request without fork repo? :-o

allentc commented 2 years ago

The usual thing to do is fork the repo and submit the PR from your fork. If you don't anticipate making further PRs then delete your fork after the PR is merged. See: Pull request without forking?

VVD commented 2 years ago

This way require fork… :-(

allentc commented 2 years ago

Well, that's standard practice with Git/GitHub. Takes about 3 seconds to make a fork.

SebDieBln commented 2 years ago

@VVD I understand you are building under FreeBSD? Do you know, why the build on Linux does not require such a patch?

VVD commented 2 years ago

@SebDieBln, yes, FreeBSD. Maybe it's clang vs gcc issue?