allenwan / thematic

Automatically exported from code.google.com/p/thematic
0 stars 0 forks source link

Important spaces after words are missing when using translated strings from the nl_NL version of Thematic. #123

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. In my case use the nl_NL translation of thematic
2.
3.

What is the expected output? What do you see instead?
Some words are attached to each other in the post header. Expected is that the 
spaces after strings should be implemented outside of the translatable strings 
in the __() and _e() functions.

What version of the product are you using? On what operating system?
Latest svn checkout 0.9.8ß

Please provide any additional information below.

When I use the dutch version of thematic mo file there are some spaces missing 
in strings like "By" (context: posted by) "Published" (context: Published by) 
in the post header. I can imagine this can be overlooked in poedit. I changed 
it myself, but maybe the strings should be without spaces in the string 
functions.

Original issue reported on code.google.com by arjenkla...@gmail.com on 11 Dec 2011 at 3:41

GoogleCodeExporter commented 9 years ago
I actually found a space at the end (and some at the beginning)of the following 
strings, can be pretty confusing for translators I think:

"Email"
"Pages:"
"Author Archives: "
"Permalink to "
"By "
"View all posts by "
"Published: "
"This entry was posted in "
"Also posted in "
"Posted in "
" Also tagged "(also a space in front of the string)
"Comment on "
" Comments "(a space in front of the string)
". Bookmark the "
" or leave a trackback: "(also a space in front of the string)
" Comments are closed, but you can leave a trackback: "(also a space in front 
of the string)
" Trackbacks are closed, but you can "(also a space in front of the string)

Original comment by arjenkla...@gmail.com on 11 Dec 2011 at 3:55

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Oke I found more of them in the latest added strings... 

Original comment by arjenkla...@gmail.com on 11 Dec 2011 at 8:32

GoogleCodeExporter commented 9 years ago
I see the benefit in removing white space and trailing punctuation from 
localization strings.

Anyone interested in working on a patch? 

Original comment by eugene.m...@gmail.com on 17 Jan 2012 at 2:51

GoogleCodeExporter commented 9 years ago
Hi,
I'd be happy to commit modifications on all these misplaced spaces and 
punctuation signs!
However, this will require the generation of a new .POT file, and consequently 
the reworking of all language files. I can handle English and French, but other 
languages might remain broken for a very long time, unless other localizers can 
fix their own language versions. What do you think?

PS: I'm happy to see that Thematic being updated again, moreover at such an 
impressive pace! Thanks, keep up the good work!

Original comment by codec...@chokebore.net on 18 Jan 2012 at 5:34

GoogleCodeExporter commented 9 years ago
Changing summary for organizational purposes.

Is that the same Chokebore from the dusty old Dope guns and F***ing in the 
Streets 7inches in my closet?

I'd be pleased if you're willing to clean up those strings in Thematic's files 
but I think it'd be best to wait on this for now until the dust settles from 
all of the inline documentation and bug squashing. This task definitely falls 
into the category of bug creation.

The mo & po files could be likely edited without needing to know the language 
since we'd  be removing leading and trailing non-language specific characters. 
I'm assuming here that all languages would be using the same punctuation and 
spacing.

Original comment by eugene.m...@gmail.com on 22 Jan 2012 at 10:00

GoogleCodeExporter commented 9 years ago

Original comment by eugene.m...@gmail.com on 23 Jan 2012 at 1:06

GoogleCodeExporter commented 9 years ago
Yes, it's the same Chokebore! They did put out a few more records since those 
dusty old 7-inch days ;o)

I'm fine with waiting on this, just let me know when you need me!

As for language files, I guess you're right, so I could try to update them all 
after my fixes. Still, it would be nice to have a native speaker proof-read 
each version anyway!

Original comment by codec...@chokebore.net on 23 Jan 2012 at 2:02

GoogleCodeExporter commented 9 years ago
Hi,

Just wanted to update this thread and say thank for inspiring us to make the 
latest 1.0.3 release focused on cleaning up localization strings. We still need 
help updating the stirngs and the good thing is that now it is much easier to 
contribute!

We installed glotpress to help the process along, you can find the translations 
here:

http://translate.thematictheme.com/projects/thematic-framework

 If you are not yet a member of the new forums, sign up at http://thematictheme.com/wp-signup.php and you can login with the same credentials at http://translate.thematictheme.com and start adding strings that are missing or incorrect. Thank you for your effort!

And as a heads up, Thematic development has moved to github. Please report 
future issues here: https://github.com/ThematicTheme/Thematic/issues

Original comment by eugene.m...@gmail.com on 28 Oct 2012 at 9:59

GoogleCodeExporter commented 9 years ago
That is great news. I'm almost done making Dutch localized version. It
works perfectly!

Thanks!
Op 28 okt. 2012 22:59 schreef <thematic@googlecode.com> het volgende:

Original comment by arjenkla...@gmail.com on 29 Oct 2012 at 11:15

GoogleCodeExporter commented 9 years ago
I added you as a validator for that locale. That will allow you to approve or 
reject the strings with waiting status. Thanks!

Original comment by eugene.m...@gmail.com on 29 Oct 2012 at 3:18

GoogleCodeExporter commented 9 years ago
Ok� great... Will I be notified of new suggestions? And is there a deadline
before any stable release of thematic?
Op 29 okt. 2012 16:18 schreef <thematic@googlecode.com> het volgende:

Original comment by arjenkla...@gmail.com on 29 Oct 2012 at 6:26

GoogleCodeExporter commented 9 years ago
I don't think that  GlotPress is capable of sending out notifications 
unfortunately. Currently there  is no schedule for release. Previously we had 
used an eternally open issue here to act as a notification system  for 
translators to catch up before releases. Maybe a listserv would work best. When 
we get something set up or move towards the next release (currently 1.0.3.2 is 
in review at WP dot Org ),  I'll comment on the localization threads here and 
at the forums at ThematicTheme.com.                                        

-G

Original comment by eugene.m...@gmail.com on 30 Oct 2012 at 2:15

GoogleCodeExporter commented 9 years ago
Is it maybe an idea to have a forum topic on localisation... I wanted to thank 
somebody for contributing, but glotpress doesnt have this functionality!

Original comment by arjenkla...@gmail.com on 22 Jan 2013 at 10:04