allenwan / thematic

Automatically exported from code.google.com/p/thematic
0 stars 0 forks source link

Add hook for bottom of #main #130

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
It would be very helpful to have a hook to add content before #main's closing 
</div>. thematic_belowmainasides is close, but only works on pages where there 
is actually a sidebar. Otherwise, the only way to add content there is to copy 
and override footer.php

Original issue reported on code.google.com by jeff.fw on 20 Jan 2012 at 12:46

GoogleCodeExporter commented 9 years ago
Labeling as enhancement.

Original comment by eugene.m...@gmail.com on 20 Jan 2012 at 8:10

GoogleCodeExporter commented 9 years ago

Original comment by eugene.m...@gmail.com on 23 Jan 2012 at 1:07

GoogleCodeExporter commented 9 years ago
what should this be called?  thematic_belowsidebar? thematic_belowmainsidebar?  

there doesn't seem to be a precedent for naming something that comes just 
inside a closing div based on that particular div... it always is named after 
the preceding div.  like thematic_belowcontainer or thematic_belowheader

Original comment by helgathe...@gmail.com on 23 Jan 2012 at 8:50

GoogleCodeExporter commented 9 years ago
patch based on : thematic_belowmainsidebar()

Original comment by helgathe...@gmail.com on 23 Jan 2012 at 8:53

Attachments:

GoogleCodeExporter commented 9 years ago
I wouldn't include "sidebar" in the name, because it should work even if the 
sidebar isn't shown at all. 

How about thematic_bottomofcontainer or thematic_endofcontainer?

Original comment by jeff.fw on 23 Jan 2012 at 8:55

GoogleCodeExporter commented 9 years ago
Oh, sorry, I meant thematic_bottomofMAIN or thematic_endofMAIN. I'm an idiot.

Original comment by jeff.fw on 23 Jan 2012 at 8:59

GoogleCodeExporter commented 9 years ago
And the name is: thematic_abovemainclose

r805

Test if you wouldn't mind. Thanks!

Original comment by eugene.m...@gmail.com on 24 Jan 2012 at 8:21

GoogleCodeExporter commented 9 years ago
Works like a charm. Thanks guys!

Original comment by m...@superrunaway.com on 24 Jan 2012 at 8:28