search

allenwan / thematic

Automatically exported from code.google.com/p/thematic
0 stars 0 forks source link

MicroFormats redux #143

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Found a HTML validation error in thematic_postmeta_authorlink.

There is an extra closing span tag when creating the authorlink when it is not 
a link.

PS I only saw it because I validated an attachment page and 
thematic_is_custom_post_type() returns true on  attachment pages.

Original issue reported on code.google.com by invistr...@gmail.com on 11 Feb 2012 at 1:27

Attachments:

GoogleCodeExporter commented 9 years ago 
I think that is the tip of the iceberg here. Forgive me for hijacking the Issue 
but its easier than starting a new issue and merging this into it.

1. The micro formats are different "nickname" vs "n" between built-in post 
types and custom post types. The sad thing is I think that is my handiwork. 

2. When the micro-formatted avatar & vcard  display is activated for in the 
theme options for the author template it spits out a lot of empty markup if the 
author meta data has not been entered.

I've got a working copy of a patch that conditionally outputs the markup on the 
author template based on different variations of possible meta input but I'm 
thinking it may be better to put it all in a function.

Original comment by eugene.m...@gmail.com on 17 Feb 2012 at 2:19