allenzhuaz / gMCPmini

Graphical Multiplicity Package (minimized gMCP package without Java dependency and focusing on graphs and testing)
https://allenzhuaz.github.io/gMCPmini
2 stars 1 forks source link

Add calcPower() from {gMCP}. #24

Open samussiah opened 2 years ago

samussiah commented 2 years ago

Hello {gMCPmini} team! @dong-xi and I are working on a similar initiative to {gMCPmini}, namely extending the library with:

We'd love to contribute to your project if possible! I'm working on migrating calcPower() from {gMCP} and setting up the requisite unit tests with {testthat} so I'd be happy to submit a PR and perhaps we can have a discussion about how to collaborate.

allenzhuaz commented 2 years ago

Thanks @samussiah for asking to contribute! PR is always welcome 🤝

Just a little bit history of this small package initiation and development. The gMCPmini package is initially developed to reduce the Java dependency, so it can be compatible with organization's restricted operating system. Later on, we migrated and modified most graphical setting and testing related functions from original gMCP package, and added a ggplot2-based flexible graphical function. We also restructured the package and added formal testing cases with testthat. Based on these focus, we did not touch the functions related to power calculation, simulation, extensive graph such as entangled graph, etc. So your proposal will surely be nice complements of this package.

FYI, potentially this repo could be moved under Merck's Github account. We can discuss what is a better way to collaborate. 😄