search

alleslabs / celatone-frontend

Celatone frontend
https://celat.one
GNU General Public License v3.0
26 stars 17 forks source link

[CFE-543]: Feat(utils): improve modules verification #1097

Closed Poafs1 closed 3 weeks ago

Poafs1 commented 3 weeks ago

Summary by CodeRabbit

linear[bot] commented 3 weeks ago

CFE-543 Improve module verification by query the list

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 10:44am
6 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **celatone-frontend-main** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/celatone-frontend-main/6tAqi8fd9tCLiqu9AT8Fxt6FLzaz)) | [Visit Preview](https://celatone-frontend-main-git-feature-cfe-543-imp-92c453-alleslabs.vercel.app) | | Aug 20, 2024 10:44am | | **initia-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/initia-celatone-frontend/H4n2yxuxpAaLkJLYqpCgXz8GpvyZ)) | [Visit Preview](https://initia-celatone-frontend-git-feature-cfe-543-i-553975-alleslabs.vercel.app) | | Aug 20, 2024 10:44am | | **neutron-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/neutron-celatone-frontend/7MJkU1SZQ4QVrLoDTHywuaJEcjiD)) | [Visit Preview](https://neutron-celatone-frontend-git-feature-cfe-543-d8e937-alleslabs.vercel.app) | | Aug 20, 2024 10:44am | | **osmosis-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/osmosis-celatone-frontend/3YDzZHA5GvqH6Lr9oqha9nCUTxwj)) | [Visit Preview](https://osmosis-celatone-frontend-git-feature-cfe-543-7ca686-alleslabs.vercel.app) | | Aug 20, 2024 10:44am | | **sei-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/sei-celatone-frontend/F7CcKNjRkSNLptgvS5ka2zKXjpp7)) | [Visit Preview](https://sei-celatone-frontend-git-feature-cfe-543-impr-d82253-alleslabs.vercel.app) | | Aug 20, 2024 10:44am | | **terra-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/terra-celatone-frontend/39ahwLrLdf5uHFsUjczzAi3kSRE5)) | [Visit Preview](https://terra-celatone-frontend-git-feature-cfe-543-im-c630d0-alleslabs.vercel.app) | | Aug 20, 2024 10:44am |
coderabbitai[bot] commented 3 weeks ago

[!WARNING]

Rate limit exceeded

@Poafs1 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 38 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 70797de4326b7c36bd53ef1ee24414ab0f257219 and bec83b90df9182bbea7e87bc2e2ad793269f777e.

Walkthrough

The recent changes streamline the module verification process by removing the selectedAddress property across various components. This adjustment enhances type safety and simplifies data handling by directly associating verification status with module objects. Additionally, the updates improve clarity and maintainability within the codebase, ensuring a more efficient interface for rendering module information.

Changes

Files Change Summary
src/lib/components/module/ModuleCard.tsx, src/lib/pages/account-details/components/modules/ModuleLists.tsx, src/lib/pages/account-details/components/modules/ModuleListsBody.tsx, src/lib/pages/interact/component/drawer/ModuleSelectDrawer.tsx, src/lib/pages/interact/component/drawer/ModuleSelectDrawerMobile.tsx, src/lib/pages/interact/component/drawer/body/DrawerBodyDesktop.tsx, src/lib/pages/interact/component/drawer/body/SelectModuleSection.tsx Removed selectedAddress property from multiple props interfaces and component implementations, simplifying their interfaces.
src/lib/pages/account-details/index.tsx Updated address handling by replacing accountAddress with hexAddress in related hooks and components.
src/lib/services/move/module/index.ts Enhanced useModulesByAddress to fetch module verification info, integrating it with existing module data.
src/lib/services/types/verification/move/index.ts Changed id field type in contracts from string to a coerced number for better type safety.
src/lib/services/verification/move/api.ts Changed return type of getMoveVerifyInfosByAddress from nullable to guaranteed response, tightening API contract.
src/lib/services/verification/move/index.ts Replaced Addr type with HexAddr in useMoveVerifyInfosByAddress to ensure address format consistency.
src/lib/types/move/module.ts Added optional isVerified property to the IndexedModule interface to indicate module verification status.

Sequence Diagram(s)

sequenceDiagram
    participant Parent as Parent Component
    participant ModuleList as ModuleLists Component
    participant ModuleCard as ModuleCard Component
    participant API as API Service

    Parent->>ModuleList: Pass hexAddress
    ModuleList->>API: Fetch modules using hexAddress
    API-->>ModuleList: Return modules data
    ModuleList->>ModuleCard: Render modules with verification status

🐇 "In the meadows where modules play,
A new path found, we chase the day.
No selected address now in sight,
Just verified modules, shining bright.
With hex we hop, a simpler way,
In code we dance, come what may!" 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
evilpeach commented 3 weeks ago

Moved to #1103