search

alleslabs / celatone-frontend

Celatone frontend
https://celat.one
GNU General Public License v3.0
28 stars 19 forks source link

[CFE-599]: Refactor(components): react select input #1149

Closed Poafs1 closed 2 months ago

Poafs1 commented 2 months ago

Summary by CodeRabbit

Release Notes

linear[bot] commented 2 months ago

CFE-599 Create base styling for `chakra-react-select`

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 5:13am
6 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **celatone-frontend-main** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/celatone-frontend-main/ACEKE5upxzkJx5XMYrngXoAzY61r)) | [Visit Preview](https://celatone-frontend-main-git-refactor-cfe-599-re-7bc6e1-alleslabs.vercel.app) | | Sep 17, 2024 5:13am | | **initia-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/initia-celatone-frontend/CoUbMm86yWh2CUsqVzHmb2byarxG)) | [Visit Preview](https://initia-celatone-frontend-git-refactor-cfe-599-06654f-alleslabs.vercel.app) | | Sep 17, 2024 5:13am | | **neutron-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/neutron-celatone-frontend/G1NrFg2aAw4rE6yuXq7vv3vN3QV6)) | [Visit Preview](https://neutron-celatone-frontend-git-refactor-cfe-599-ddaacf-alleslabs.vercel.app) | | Sep 17, 2024 5:13am | | **osmosis-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/osmosis-celatone-frontend/J6Y4mJBAfioxadghvLnri97sqPeH)) | [Visit Preview](https://osmosis-celatone-frontend-git-refactor-cfe-599-c1ae52-alleslabs.vercel.app) | | Sep 17, 2024 5:13am | | **sei-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/sei-celatone-frontend/8qBEzYkziTGi2zLiCZ2XcVZawjFA)) | [Visit Preview](https://sei-celatone-frontend-git-refactor-cfe-599-rea-03d03f-alleslabs.vercel.app) | | Sep 17, 2024 5:13am | | **terra-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/terra-celatone-frontend/BBPYgLAFoTWwuDEcHdd2HcGndGCR)) | [Visit Preview](https://terra-celatone-frontend-git-refactor-cfe-599-r-cb2f20-alleslabs.vercel.app) | | Sep 17, 2024 5:13am |
coderabbitai[bot] commented 2 months ago

Walkthrough

The changes involve a significant refactor of various components within the codebase, particularly focusing on the select input functionality. The SelectInput component has been replaced with SelectInputBase in multiple files, indicating a shift towards a more standardized implementation. Additionally, several components have been updated to utilize a new structure for handling asset options, enhancing type safety and clarity. The refactor also includes modifications to props and the introduction of new interfaces, streamlining the overall component architecture.

Changes

Files Change Summary
src/lib/components/TxRelationSelection.tsx, src/lib/components/forms/FilterByPermission.tsx, src/lib/components/forms/index.ts, src/lib/components/fund/index.tsx, src/lib/pages/pools/components/FilterByPoolType.tsx, src/lib/pages/proposal-details/components/vote-details/voting-period/validator-votes-table/index.tsx, src/lib/pages/proposal-details/components/vote-details/voting-period/votes-table/index.tsx, src/lib/pages/validator-details/components/tables/voted-proposals/index.tsx, src/lib/pages/validators/components/ActiveFilter.tsx, src/lib/pages/validators/components/OrderSelect.tsx Renamed SelectInput to SelectInputBase, indicating a shift in the underlying implementation or functionality.
src/lib/components/forms/SelectInput.tsx, src/lib/components/forms/SelectInputBase.tsx Refactored SelectInput to utilize the Select component from chakra-react-select, simplifying the structure and enhancing usability. Introduced SelectInputBase as a new customizable select input component with internal state management and enhanced props for better functionality.
src/lib/components/forms/asset-input/AssetInputFormatOptionLabel.tsx, src/lib/components/forms/asset-input/AssetInputMenuList.tsx, src/lib/components/forms/asset-input/AssetInputNoOptionsMessage.tsx, src/lib/components/forms/asset-input/AssetInputOption.tsx, src/lib/components/forms/asset-input/index.tsx Updated to work with a new structured option type, enhancing type safety and clarity in handling asset options.
src/lib/components/modal/wasm-verify-submit/WasmVerifySubmitFormSelect.tsx, src/lib/components/modal/wasm-verify-submit/WasmVerifySubmitFormSelectNoOptionsMessage.tsx, src/lib/components/modal/wasm-verify-submit/WasmVerifySubmitFormSelectOption.tsx Refactored to utilize the new SelectInput component and updated type definitions for options, enhancing flexibility and maintainability.
src/lib/types/asset.ts Introduced a new interface AssetOptionValue for a more detailed representation of asset options and modified the AssetOption type to be based on SelectInputOption.
src/lib/components/forms/forms/FilterByPermission.tsx Updated import statements and component usage to reflect the new structure and naming conventions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FilterComponent
    participant SelectInputBase
    participant AssetOptions

    User->>FilterComponent: Select an option
    FilterComponent->>SelectInputBase: Trigger selection change
    SelectInputBase->>AssetOptions: Fetch available options
    AssetOptions-->>SelectInputBase: Return options
    SelectInputBase-->>FilterComponent: Update selected option
    FilterComponent-->>User: Display updated selection

🐇 In the code, we hop and play,
New inputs lead the way!
With options bright and clear,
Selecting brings us cheer!
A refactor, oh so neat,
Makes our forms a tasty treat! 🥕

Possibly related PRs

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between a9459620b6f792154c8fe9fefd9e42361efc5a09 and b56276a0c2f616de881ee595641cbe37198d6900.
Files ignored due to path filters (1) * `pnpm-lock.yaml` is excluded by `!**/pnpm-lock.yaml`
Files selected for processing (1) * CHANGELOG.md (1 hunks)
Files skipped from review as they are similar to previous changes (1) * CHANGELOG.md
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai generate interesting stats about this repository and render them as a table.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Early access features: enabled We are currently testing the following features in early access: - **OpenAI `o1` for code reviews**: OpenAI's new o1 model is being tested for generating code suggestions in code reviews. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.