alleslabs / celatone-frontend

Celatone frontend
https://celat.one
GNU General Public License v3.0
28 stars 19 forks source link

feat: account redirects #1151

Closed songwongtp closed 2 months ago

songwongtp commented 2 months ago

Summary by CodeRabbit

Release Notes

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 5:45am
6 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **celatone-frontend-main** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/celatone-frontend-main/GrFYknS7ZzgA6Ho4FUpcxS5Vfk5R)) | [Visit Preview](https://celatone-frontend-main-git-feat-evm-misc-alleslabs.vercel.app) | | Sep 13, 2024 5:45am | | **initia-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/initia-celatone-frontend/Gah4pzEexc1hzJ5DmWJiF762hsXi)) | [Visit Preview](https://initia-celatone-frontend-git-feat-evm-misc-alleslabs.vercel.app) | | Sep 13, 2024 5:45am | | **neutron-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/neutron-celatone-frontend/CyWwr2S5yigF9oKQJXXmoxq4D1CW)) | [Visit Preview](https://neutron-celatone-frontend-git-feat-evm-misc-alleslabs.vercel.app) | | Sep 13, 2024 5:45am | | **osmosis-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/osmosis-celatone-frontend/EE9V2DgpnmuBysFZBW887oW6ZV3W)) | [Visit Preview](https://osmosis-celatone-frontend-git-feat-evm-misc-alleslabs.vercel.app) | | Sep 13, 2024 5:45am | | **sei-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/sei-celatone-frontend/EWBcyvzAkdb8Tp7txxRTwUYtDV9C)) | [Visit Preview](https://sei-celatone-frontend-git-feat-evm-misc-alleslabs.vercel.app) | | Sep 13, 2024 5:45am | | **terra-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/terra-celatone-frontend/Ds392r8Yi5fwWEPpW9Urh1HXG4cP)) | [Visit Preview](https://terra-celatone-frontend-git-feat-evm-misc-alleslabs.vercel.app) | | Sep 13, 2024 5:45am |
coderabbitai[bot] commented 2 months ago

Walkthrough

The recent update introduces new redirect logic for specific application paths, enhancing user navigation. The /address path now redirects to /accounts, while the /accounts path can redirect to either /contracts or /evm-contracts. Additionally, improvements to the loading logic for EVM contracts and transactions have been made, alongside an update to the package manager and a refactor of EVM denomination handling. New properties have been added to components for better token amount formatting, and new hooks have been implemented to manage account and transaction redirection based on address validation.

Changes

File Change Summary
CHANGELOG.md, next.config.js Added redirect logic for /address to /accounts and /accounts to either /contracts or /evm-contracts. Introduced new routing rules for account addresses in next.config.js.
src/lib/components/token/TokenImageWithAmount.tsx Added hasTrailingZeros property to TokenImageWithAmountProps, allowing control over trailing zero display in token amounts.
src/lib/pages/account-details/hooks/index.ts Re-exported all exports from the useAccountRedirect module for improved modularity.
src/lib/pages/account-details/hooks/useAccountRedirect.ts Introduced useAccountRedirect hook for navigation based on blockchain address validation, handling both Bech32 and hexadecimal addresses.
src/lib/pages/account-details/index.tsx Added loading state in AccountDetailsBody to display while checking for redirects.
src/lib/pages/contract-details/index.tsx Simplified loading state rendering in ContractDetailsBody by removing conditional check for null contracts.
src/lib/pages/evm-tx-details/components/EvmTxGasReceipt.tsx Modified parameters in formatTokenWithValue to prevent displaying trailing zeros in gas receipt information.
src/lib/pages/evm-tx-details/components/EvmTxInfo.tsx Added hasTrailingZeros prop to TokenImageWithAmount to control trailing zero display.
src/lib/pages/evm-tx-details/components/EvmTxInfoMobile.tsx Added hasTrailingZeros prop to TokenImageWithAmount for cleaner amount display.
src/lib/utils/evm.ts Modified getEvmToAddress function to set type property to "user_address" unconditionally, removing differentiation based on method type.
src/lib/utils/formatter/formatTokenWithValue.ts Added hasTrailingZeros parameter to formatTokenWithValue for flexible token amount formatting.
src/lib/utils/formatter/token.ts Added hasTrailingZeros parameter to formatDecimal and formatUTokenWithPrecision functions for improved control over decimal formatting.

Possibly related PRs

Poem

🐇 In the garden of code, where changes bloom,
New paths are laid, dispelling the gloom.
Redirects now dance, from address to account,
With tokens displayed, in a cleaner amount.
A hop and a skip, through logic so bright,
User journeys enhanced, in the soft moonlight! 🌙

[!TIP]

OpenAI O1 model for chat - We have deployed OpenAI's latest O1 model for chat. - OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model. - Please share any feedback with us in the [discussions post](https://discord.com/channels/1134356397673414807/1283929536186155099).

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 1fc2d524a38dce8ce9dab5c95154a26d65f4398b and 04f0d08db9d1bb33838d37fecd0423c4bd270181.
Files selected for processing (5) * src/lib/pages/account-details/index.tsx (4 hunks) * src/lib/pages/contract-details/index.tsx (0 hunks) * src/lib/pages/tx-details/hooks/index.ts (1 hunks) * src/lib/pages/tx-details/hooks/useTxRedirect.ts (1 hunks) * src/lib/pages/tx-details/index.tsx (2 hunks)
Files not reviewed due to no reviewable changes (1) * src/lib/pages/contract-details/index.tsx
Files skipped from review due to trivial changes (1) * src/lib/pages/tx-details/hooks/index.ts
Files skipped from review as they are similar to previous changes (1) * src/lib/pages/account-details/index.tsx
Additional comments not posted (4)
src/lib/pages/tx-details/hooks/useTxRedirect.ts (1)
`3-13`: **LGTM!** The `useTxRedirect` hook is well-structured and follows best practices: - It has a clear and focused responsibility of redirecting to the EVM transaction details page based on the provided `txHash`. - It uses the `useEvmConfig` and `useInternalNavigate` hooks appropriately. - The function is small and readable, with clear variable names and early return statements. - It aligns with the Single Responsibility Principle (SRP). Great job!
src/lib/pages/tx-details/index.tsx (3)
`17-17`: **LGTM!** The import statement for the `useTxRedirect` hook is correct. --- `20-22`: **LGTM!** The code segment correctly initializes the `isMobile` and `router` variables. --- Line range hint `24-43`: **LGTM!** The code segment correctly handles the transaction redirect logic using the `useTxRedirect` hook and renders the loading state appropriately based on the redirect check and data fetching status. The changes align with the AI-generated summary and do not introduce any issues.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.