search

alleslabs / celatone-frontend

Celatone frontend
https://celat.one
GNU General Public License v3.0
28 stars 19 forks source link

fix: remove isPrettyNameExist #1176

Closed evilpeach closed 2 weeks ago

evilpeach commented 2 weeks ago

Summary by CodeRabbit

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 2:10pm
6 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **celatone-frontend-main** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/celatone-frontend-main/4a1jyHYffr6HiJMqZ8J7eh2PftUg)) | [Visit Preview](https://celatone-frontend-main-git-fix-adding-network-by-url-alleslabs.vercel.app) | | Nov 3, 2024 2:10pm | | **initia-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/initia-celatone-frontend/5GrWNLgKTe3g876DsRKk8wNMFH2g)) | [Visit Preview](https://initia-celatone-frontend-git-fix-adding-networ-16b7cc-alleslabs.vercel.app) | | Nov 3, 2024 2:10pm | | **neutron-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/neutron-celatone-frontend/2FQ1JLEA1VuJpsTNr59C3qFcTux3)) | [Visit Preview](https://neutron-celatone-frontend-git-fix-adding-netwo-4a3e00-alleslabs.vercel.app) | | Nov 3, 2024 2:10pm | | **osmosis-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/osmosis-celatone-frontend/71b8fEf8SfGu2KUxy522GtGAecgm)) | [Visit Preview](https://osmosis-celatone-frontend-git-fix-adding-netwo-2939f8-alleslabs.vercel.app) | | Nov 3, 2024 2:10pm | | **sei-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/sei-celatone-frontend/BNY2eYmZTRcR2pAVGLHF2fd6vacq)) | [Visit Preview](https://sei-celatone-frontend-git-fix-adding-network-by-url-alleslabs.vercel.app) | | Nov 3, 2024 2:10pm | | **terra-celatone-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/alleslabs/terra-celatone-frontend/5Kfg1YQ4uSEwAjnje2KinPm8FuKK)) | [Visit Preview](https://terra-celatone-frontend-git-fix-adding-network-by-url-alleslabs.vercel.app) | | Nov 3, 2024 2:10pm |
coderabbitai[bot] commented 2 weeks ago

Walkthrough

The pull request introduces updates to the CHANGELOG.md file to document new features, improvements, and bug fixes. Notably, it includes a feature for adding a custom network via URL with a query parameter and improvements to its functionality. Additionally, several bug fixes are recorded, such as issues with tooltip background color and mobile drawer auto-popup. Changes are also made to the AddNetworkLink, AddNetworkJson, and AddNetworkManual components, enhancing error handling and simplifying validation logic for network configurations.

Changes

File Change Summary
CHANGELOG.md Updated to include entries for new feature (custom network by URL), improvements, and bug fixes.
src/lib/pages/custom-network/link/index.tsx Modified error handling for router.query.config, simplified validation logic, added console error logging.
src/lib/app-provider/hooks/useChainConfigs.ts Removed isPrettyNameExist method from hook return type, simplifying chain configuration checks.
src/lib/pages/custom-network/json/index.tsx Removed isPrettyNameExist check from duplicate modal logic, simplifying the submission process.
src/lib/pages/custom-network/manual/index.tsx Removed isPrettyNameExist from validation logic and function calls, streamlining the component.
src/lib/pages/custom-network/types.ts Updated ValidateExistingChain interface and related functions to remove isPrettyNameExist, simplifying validation logic.

Possibly related PRs

Suggested reviewers

Poem

In the meadow where networks grow,
A custom link now starts to flow.
With fixes bright and logic clear,
Adding chains brings us good cheer!
Hop along, let’s celebrate,
New features make us elevate! 🐇✨

📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between 66b901c34f22088f50d18fd6f082d5e747e9e5e2 and cc626ded7b98c731c3b4b5bb941fa190038b025a.
📒 Files selected for processing (1) * `src/lib/pages/custom-network/types.ts` (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * src/lib/pages/custom-network/types.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.