search

alleyinteractive / .github

https://alley.com
1 stars 1 forks source link

Issue-86: Allow building of project during testing #87

Closed anubisthejackle closed 2 weeks ago

anubisthejackle commented 4 months ago

Summary

This pull request aims to introduce the capability to execute NPM install and NPM scripts during the testing process, addressing the need specified in issue #86. This change would allow projects to build appropriately before testing, ensuring that all necessary files are present in the /build directory for a successful test run.

Fixes #86

Background

Currently, some projects like wp-conditional-blocks face challenges during the testing phase due to the build process only copying PHP files to the /build directory. Without this change, testing cannot accurately reflect the project's state, leading to potential failures.

Implementation

The proposed solution involves modifying the testing workflow to include steps for running npm install followed by relevant NPM scripts. This ensures that all necessary build processes are completed before testing commences.

Testing

To verify the effectiveness of this change, projects that previously failed in the testing phase due to build issues will be retested. Success is defined by the ability to execute tests without encountering errors related to missing files in the /build directory.

Additional Notes

This change is crucial for improving the reliability of our testing process and ensuring that all projects can be accurately tested before deployment.

For more details, see the original issue at https://github.com/alleyinteractive/.github/issues/86.

kevinfodness commented 2 weeks ago

Moved this functionality to Alley's reusable actions, which makes this possible by using the node tests action before the php tests action.