alleyinteractive / ad-layers

Ad Layers WordPress Plugin
Other
26 stars 12 forks source link

Script tag are being stripped out on VIP Platform #60

Open kala725 opened 7 years ago

kala725 commented 7 years ago

While serving the ad-layers through widgets, script tag is being stripped out, leaving the javascript code to be displayed on the site. How can we fix or is there something I am doing wrong ?

Cause : In plugins/ad-layers/php/class-ad-layers-widget.php , on line no.50 "wp_kses_post" is stripping the missing, causes the above script code to be shown on the UI of the site.

<div id="xxx_xontainer__" style="border: 0pt none;"><iframe id="xxx_xontainer__" title="3rd party ad content" name="xxx_xontainer__" width="300" height="250" scrolling="no" marginwidth="0" marginheight="0" frameborder="0" srcdoc="" style="border: 0px; vertical-align: bottom;"></iframe></div></div></li>

Hope it is clear now. It is a issue, Meanwhile I am also working on it, and will send a fix, if I can debug it first.

kala725 commented 7 years ago

Hi @bcampeau : For myself, I have fixed this issue by reverting ad-layers back on the checkout id "aba3ab4". Previously I was on master. Now You can check on why has broke it in master. If I have time, I will also check the changes.

bcampeau commented 7 years ago

To confirm, are you using the widget that's built into the plugin or some other widget?

kala725 commented 7 years ago

Hi Bradford, I am using the built-in widget of the plugin. (No customization's to the plugin at all)

Thanks & Regards :

Arvind Kala

On Thu, Feb 9, 2017 at 10:12 PM, Bradford Campeau-Laurion < notifications@github.com> wrote:

To confirm, are you using the widget that's built into the plugin or some other widget?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/alleyinteractive/ad-layers/issues/60#issuecomment-278698364, or mute the thread https://github.com/notifications/unsubscribe-auth/AHmNmlN5rmoZZ2zQsXHP42vc2p-gzFwPks5ra0HZgaJpZM4L7G2z .

davisshaver commented 6 years ago

@kala725 @bcampeau I believe this was fixed in https://github.com/alleyinteractive/ad-layers/pull/67

Although I do not know if this patch has made its way to VIP servers yet