alleyinteractive / byline-manager

Manage an article's byline and author profiles in WordPress.
GNU General Public License v3.0
3 stars 2 forks source link

Support Windows Paths #219

Closed kevinfodness closed 10 months ago

kevinfodness commented 11 months ago

Description of the bug

The code checks paths for "validity" by checking the return value of validate_file to ensure that it is 0, but a valid Windows filepath on a Windows system will return 2, making it so that this plugin cannot run on a Windows host (either for local development or via Windows Server).

Steps To Reproduce

  1. Install this plugin on Windows
  2. Observe that the Gutenberg customizations do not work as expected due to the asset dependencies logic

Additional Information

Should replace the validate_file check to ensure it returns either 0 or 2