alleyinteractive / sasslint-webpack-plugin

A webpack plugin to lint your SCSS/SASS code
MIT License
33 stars 12 forks source link

Not using configFile and requires full path to ignored files #25

Open mikeerickson opened 8 years ago

mikeerickson commented 8 years ago

I have the following (configuration)

    new SassLintPlugin({
      configFile: '.sass-lint.yml',
      ignoreFiles: [
        '/Users/mikeerickson/Documents/Projects/angular-sandbox/src/sass/mixins/text.sass',
        './src/sass/modules/_reset.scss'
      ]
    }),

Here is my result when running webpack

...
/Users/mikeerickson/Documents/Projects/angular-sandbox/src/sass/modules/_reset.scss
   1:6   warning  Selectors must be placed on new lines                           single-line-per-selector
   1:12  warning  Selectors must be placed on new lines                           single-line-per-selector
...

As you can see, the _reset.scss file is still being checked, despite its defined ignore item

mikeerickson commented 8 years ago

Well, looks like pilot error (for ingnore option). But still curious about reading files from .sass-lint.yml file

From the docs (sorry didn't read this thoroughly)

So, the question still remains. If I have the following in .sass-lint.yml file, should plugin use these entires?

files:
  include:
    - "./src/sass/**/*.s+(a|c)ss"
  ignore:
    - "./src/sass/disabled/**/*.s+(a|c)ss"
    - "./src/sass/modules/*.s+(a|c)ss"
    - "node_modules/**/*.s+(a|c)ss"
jackmarketon commented 8 years ago

We aren't parsing the sasslint config for ignores so that's might not work (haven't tested it TBH).

idangozlan commented 7 years ago

Why the plugin is not reading the ignored files from config file?

jackmarketon commented 7 years ago

@idangozlan I'm sorry, but we are no longer doing active development on this plugin. Thus I cannot answer that question.