search

alleyinteractive / searchpress

Elasticsearch integration for WordPress.
84 stars 12 forks source link

Manually check for queried taxonomy terms when building facets #151

Closed kevinfodness closed 2 years ago

kevinfodness commented 2 years ago

Fixes #150

mboynes commented 2 years ago

Would love to see a unit test added for this prior to merge. I can do it if you don't have time @kevinfodness

kevinfodness commented 2 years ago

I can handle.

kevinfodness commented 2 years ago

@mboynes I added a test for facet selection. In order to do that, for compatibility with phpunit in the latest version of WP, I also needed to move phpunit to composer, which I've also done with phpcs. The phpcs ruleset will fail if you run it locally, and we'll need another PR later to fix that up prior to activating the check in #145.