Adhere to WP Coding Standards

mboynes commented 9 years ago

We are aiming to enforce the WordPress coding standards across the entire plugin.

We'd love some help doing this spring cleaning. Below is a list of files that need to be verified or updated. If you want to chip in, comment on this issue saying that you're going to take one, and we'll update the issue to say you're on it. Then simply submit a PR with the clean file when you're done.

PHP

[x] fieldmanager.php
[x] php/class-fieldmanager-autocomplete.php
[x] php/class-fieldmanager-checkbox.php
[x] php/class-fieldmanager-checkboxes.php
[x] php/class-fieldmanager-colorpicker.php
[x] php/class-fieldmanager-datepicker.php
[x] php/class-fieldmanager-draggablepost.php
[x] php/class-fieldmanager-field.php
[x] php/class-fieldmanager-grid.php
[x] php/class-fieldmanager-group.php
[x] php/class-fieldmanager-hidden.php
[x] php/class-fieldmanager-link.php
[x] php/class-fieldmanager-media.php
[x] php/class-fieldmanager-options.php
[x] php/class-fieldmanager-password.php
[x] php/class-fieldmanager-radios.php
[x] php/class-fieldmanager-richtextarea.php
[x] php/class-fieldmanager-select.php
[x] php/class-fieldmanager-textarea.php
[x] php/class-fieldmanager-textfield.php
[x] php/context/class-fieldmanager-context-page.php
[x] php/context/class-fieldmanager-context-post.php
[x] php/context/class-fieldmanager-context-quickedit.php
[x] php/context/class-fieldmanager-context-storable.php
[x] php/context/class-fieldmanager-context-submenu.php
[x] php/context/class-fieldmanager-context-term.php
[x] php/context/class-fieldmanager-context-user.php
[x] php/context/class-fieldmanager-context.php
[x] php/datasource/class-fieldmanager-datasource-post.php
[x] php/datasource/class-fieldmanager-datasource-term.php
[x] php/datasource/class-fieldmanager-datasource-user.php
[x] php/datasource/class-fieldmanager-datasource.php
[x] php/util/class-fieldmanager-util-term-meta.php
[x] php/util/class-fieldmanager-util-validation.php
[x] templates/datepicker.php
[x] templates/options-checkboxes.php
[x] templates/options-radios.php
[x] templates/textfield.php
JS
[ ] js/fieldmanager-autocomplete.js
[ ] js/fieldmanager-colorpicker.js
[ ] js/fieldmanager-datepicker.js
[ ] js/fieldmanager-draggablepost.js
[ ] js/fieldmanager-group-tabs.js
[ ] js/fieldmanager-post.js
[ ] js/fieldmanager-quickedit.js
[ ] js/fieldmanager-select.js
[ ] js/fieldmanager.js
[ ] js/grid.js
[ ] js/media/fieldmanager-media.js
[ ] js/richtext.js
[ ] js/validation/fieldmanager-validation.js

danielbachhuber commented 8 years ago

We're set up to do cleanup now, but because of the code churn required, we should do it as the very last thing.

montchr commented 8 years ago

If you still need help with this still, I'm willing to take a few files.

danielbachhuber commented 8 years ago

If you still need help with this still, I'm willing to take a few files.

Great! I think now's a good time for it, given we're at the beginning of the next cycle and don't have too many outstanding pull requests.

Can you submit pull requests file by file, and enable PHPCS validation by Travis on the file at the beginning of the cleanup process? This will let us capture a failing build with all of the validations, and work towards a passing build.