search

alleyinteractive / wp-alleyvate

Defaults for WordPress sites by Alley.
GNU General Public License v2.0
16 stars 2 forks source link

[Feature] Unit tests for the Full-Page Caching for 404s feature #76

Closed renatonascalves closed 5 months ago

renatonascalves commented 5 months ago

Summary

As titled.

Notes for reviewers

See https://github.com/alleyinteractive/wp-alleyvate/pull/46

renatonascalves commented 5 months ago

Looks like the php-cs-fixer doesn't like the <<<HTML indentation. But I could not make it work. 🤔

renatonascalves commented 5 months ago

I made it work but it seems we have conflicting tools here asking for different rules: php-cs-fixer vs phpcs.

renatonascalves commented 5 months ago

Getting the object-cache to work here is proving more complicated than expected. Moving on as it is for now while I search for better support. Probably changing https://github.com/alleyinteractive/.github/blob/main/.github/workflows/php-tests.yml