search

allfed / ALLFED-Repository-Template

Use this as a template for a new project: https://medium.com/programming-lite/repository-templates-in-github-why-how-75b1d1bd43f2
Apache License 2.0
2 stars 6 forks source link

Adding isort #11

Open florianjehn opened 1 year ago

florianjehn commented 1 year ago

isort makes that all imports are ordered the same way throughout our code: https://pycqa.github.io/isort/

It would be great if this would simply run for every commit pushed to the repository.

Was not able to get it to work with GIthub Actions and help would be appreciated.

lukaszgajewski commented 3 weeks ago

It seems that it's not supported by the github action we use: https://github.com/wearerequired/lint-action/issues/356 There is a fork we could consider: https://github.com/Gobot1234/lint-action or add it ourselves: https://github.com/wearerequired/lint-action/blob/master/CONTRIBUTING.md#adding-a-new-linter.

florianjehn commented 3 weeks ago

Like the other issue, not really important, but if you think you can fix this without much effort feel free to send a pull request.