allfed / allfed-integrated-model

Integrated model to calculate the effects of resilient foods in catastrophic events
https://allfed.github.io/allfed-integrated-model/
GNU General Public License v3.0
11 stars 10 forks source link

SWZ/SWT confusion #138

Open lukaszgajewski opened 1 month ago

lukaszgajewski commented 1 month ago

In the code, there is a change of the ISO3 code "SWZ" to "SWT". I have failed to find the source of this change and the ISO itself lists Eswatini as SWZ, not SWT. The fix should be rather simple -- this line and the next, and this function, as well as miscellaneous "SWT" references throughout the codebase need to be removed. However, there might be a concrete reason for this change that I am unaware of.

morganrivers commented 1 month ago

We talked through this.

It was due to an old issue with "world" from pandas. I think the reasoning was that there was a conflict in that Switzerland also used the SWZ iso3 code. But now switzerland is consistently CHE, and eswatini is consistently SWZ, so we should remove all instances of SWT conversion in the code.

Again, all instances of SWT should be removed, and SWZ should always be used instead. That would clean things up.